Skip to content

ci/eval/nix: 2.24 -> ...#404589

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
roberth:ci-nix-2.28
May 17, 2025
Merged

ci/eval/nix: 2.24 -> ...#404589
wolfgangwalther merged 1 commit intoNixOS:masterfrom
roberth:ci-nix-2.28

Conversation

@roberth
Copy link
Copy Markdown
Member

@roberth roberth commented May 6, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@roberth roberth requested a review from Mic92 May 6, 2025 09:05
@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions backport release-24.11 labels May 6, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 6, 2025
Copy link
Copy Markdown
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❯ git log --oneline pinned-nixpkgs.json
ffe6651ecebf Revert "ci: Update pinned Nixpkgs"
0fe5843ab46e ci: Update pinned Nixpkgs
1d6ee7d8eef7 ci: Update pinned Nixpkgs
d51aeeb1fbc7 ci: Update pinned Nixpkgs
d979e89d8811 ci: Update pinned Nixpkgs
c9bbb9962cf7 ci: Update pinned Nixpkgs
7aa5bc804303 ci: Update pinned Nixpkgs
8e1b9b9eb381 ci/pinned-nixpkgs.json: update
b33ac05d043c ci: reusable Nix format Nixpkgs pin

@wolfgangwalther wolfgangwalther changed the title ci/nix: 2.24 -> 2.28 ci/eval/nix: 2.24 -> 2.28 May 11, 2025
@wolfgangwalther
Copy link
Copy Markdown
Contributor

I'd say we do #404466 first, which will allow us to validate the update of pinned nixpkgs easily locally.

@wolfgangwalther
Copy link
Copy Markdown
Contributor

pin updated in #406909.

Copy link
Copy Markdown
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a slightly preference for using latest here, or anything that is not a pinned version. Doesn't make sense to maintain this on top of the pinned nixpkgs we already have.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels May 17, 2025
@roberth roberth changed the title ci/eval/nix: 2.24 -> 2.28 ci/eval/nix: 2.24 -> ... May 17, 2025
@wolfgangwalther wolfgangwalther merged commit 17fbc7b into NixOS:master May 17, 2025
17 of 21 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented May 17, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants